SNOW-2019071: Remove Dependency on Amazonaws and Guava isNullOrEmpty Method#2142
Closed
sfc-gh-wfateem wants to merge 1 commit intomasterfrom
Closed
SNOW-2019071: Remove Dependency on Amazonaws and Guava isNullOrEmpty Method#2142sfc-gh-wfateem wants to merge 1 commit intomasterfrom
sfc-gh-wfateem wants to merge 1 commit intomasterfrom
Conversation
12 tasks
sfc-gh-wfateem
force-pushed
the
SNOW-2019071-isNullOrEmpty
branch
from
9fe3af3 to
dc54977
Compare
sfc-gh-wfateem
force-pushed
the
SNOW-2019071-isNullOrEmpty
branch
from
dc54977 to
eb0207a
Compare
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Collaborator
Author
|
Closing this PR. Refer to #2143 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the code to add an implementation for the isNullOrEmpty(String) method rather than using Guava Strings.isNullOrEmpty and Amazonaws StringUtils.isNullOrEmpty in different places.